add case/switch statement code smell #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Chris, I must apologise for not noticing your PR earlier. Thanks for taking the time. The thing is, we already have a code smell "Repeated Switches" (https://sammancoaching.org/code_smells/repeated_switches.html). The smell you refer to as "Case or Switch Statements" I think is from the first edition of Martin Fowler's Refactoring book. It is changed in the second edition to "Repeated Switches". I don't think it's necessary to have both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently helped someone with this code smell, and thought it could be good to add to the website, especially to highlight that
caseorswitchstatements aren't necessarily "bad," but that they could be hiding something better.